-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flasher and hierarchical config manager #110
base: master
Are you sure you want to change the base?
Conversation
Exceptional work, I'll work through reviewing this tomorrow. |
Another focus should be to get preview deployments building (broken package lock atm) |
Just built this locally to check out and wow! This is very impressive! I have some feedback but it might be a little premature for that, so I'll hold off for now. I'm very excited for what comes out of this though. Great job so far! |
disabledBy: [ | ||
{ | ||
fieldName: "usePreset" | ||
} | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reasoning behind having all options enabled?
@rcarteraz happy for any feedback |
Sounds good. I'm out right now but I'll post when I get back this evening. |
Auto-detect for updates should be doable if a want-config is called and we get the HWModel from the DeviceMetadata payload. |
Auto detect is pretty much impossible if the device does not have Meshtastic on it yet so a manual path is always needed devices with Meshtastic can be identified as @thebentern stated. |
Is there a risk to any existing functionality by merging this? Seems like great features separate from the existing functionally that we can patch as we find stuff. The pull is starting to get stale which is never any fun for a large pull. |
Hi, is this still being worked on? Because it does sound like it's exactly what i'm looking for (though i haven't tested it out yet). If it's too "overwhelming" for new users, maybe add and "Advanced" toggle in the UI (or via env vars for the container) to hide/show this added functionality. |
This adds the possibility to flash and configure multiple boards with varying configs.
Configurations can be created in a tree-like structure and each (except the root) inherit values from their parent and can override certain fields.
For each config it can then be specified how many boards shall be given the specific config, an example would be to have a couple of nodes with Bluetooth enabled and several with GPS configured. Setting the LoRa region in the root config is probably a good idea.
Slight modifications on the
js
package are needed, hence the depency currently points to this fork.Feedback appreaciated